EventFiring objects. The addition to event firing WebDriver#559
Merged
TikhomirovSergey merged 4 commits intoappium:masterappium/java-client:masterfrom Jan 29, 2017
TikhomirovSergey:masterCopy head branch name to clipboard
Merged
EventFiring objects. The addition to event firing WebDriver#559TikhomirovSergey merged 4 commits intoappium:masterappium/java-client:masterfrom TikhomirovSergey:masterCopy head branch name to clipboard
TikhomirovSergey merged 4 commits intoappium:masterappium/java-client:masterfrom
TikhomirovSergey:masterCopy head branch name to clipboard
Conversation
- EventFiringObjectFactory was added - The refactoring of EventFiringWebDriverFactory DefaultBeanConfiguration
SrinivasanTarget
approved these changes
Jan 28, 2017
Member
SrinivasanTarget
left a comment
There was a problem hiding this comment.
LGTM. Codacy have to be happy :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
EventFiringWebDriverFactoryandDefaultBeanConfiguration.DefaultAspectwas actualized.Types of changes
Details
Motivation
As soon as we have made API with default implementation. I think it would be cool to get objects created by these interfaces (anonymous types) listenable. Also the good option is to make some objects (some single element that has been found) listenable too.