Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

#552 FIX#556

Merged
TikhomirovSergey merged 10 commits intoappium:masterappium/java-client:masterfrom
TikhomirovSergey:masterCopy head branch name to clipboard
Jan 20, 2017
Merged

#552 FIX#556
TikhomirovSergey merged 10 commits intoappium:masterappium/java-client:masterfrom
TikhomirovSergey:masterCopy head branch name to clipboard

Conversation

@TikhomirovSergey
Copy link
Contributor

Change list

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

There is #552 FIX.
Generating of RemoteWebElement is normal now. It should happen when current driver is swithed to WebView/browser. Otherwise it generates native Android/iOS etc elements according to platformName parameter of the current session

- HasSessionDetails declares two additional methods now:  String getPlatformName() and String  getAutomationName()
- these methods are re-implemented by AppiumDriver.
- AppiumFieldDecorator refactoring
- HasSessionDetails declares the additional method isBrowser()
- improving of element generating engine
- IOSElementGenerationTest was designed
- AndroidElementGeneratingTest was re-designed
Copy link
Member

@SrinivasanTarget SrinivasanTarget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

# Conflicts:
#	src/main/java/io/appium/java_client/AppiumDriver.java
#	src/test/java/io/appium/java_client/appium/element/generation/ios/IOSElementGenerationTest.java
@TikhomirovSergey TikhomirovSergey merged commit 02b5b64 into appium:master Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.