Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

#549 FIX#551

Merged
TikhomirovSergey merged 1 commit intoappium:masterappium/java-client:masterfrom
TikhomirovSergey:masterCopy head branch name to clipboard
Jan 2, 2017
Merged

#549 FIX#551
TikhomirovSergey merged 1 commit intoappium:masterappium/java-client:masterfrom
TikhomirovSergey:masterCopy head branch name to clipboard

Conversation

@TikhomirovSergey
Copy link
Contributor

Change list

  • ByChained was re-implemented. Now it fairly searches for a single element when it is required
  • AppiumElementLocator refactoring
  • new tests were provided

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

#549 FIX

@TikhomirovSergey
Copy link
Contributor Author

@saikrishna321 Could you review this PR too? Also it would be cool if you built the jar using these changes and tried to reproduce the issue/confirm that it is resolved on your app?

@saikrishna321
Copy link
Member

@TikhomirovSergey not able to build locally

FAILURE: Build failed with an exception.

* What went wrong:
Error while evaluating property 'signatory' of task ':signArchives'
> Unable to retrieve secret key from key ring file '/Users/saikrisv/git/java_client_pr/java-client/PathToYourKeyRingFile' as it does not exist

@SrinivasanTarget
Copy link
Member

@saikrishna321 You can exclude it ./gradlew clean build -x test -x signArchives

@saikrishna321
Copy link
Member

- ByChained was re-implemented. Now it fairly searches for a single element when it is required
- AppiumElementLocator refactoring
- new tests were provided
@TikhomirovSergey
Copy link
Contributor Author

TikhomirovSergey commented Jan 2, 2017

@saikrishna321
Yes. I have got it fixed now. I hope this is the final commit. There is my last server output
https://gist.github.com/TikhomirovSergey/3306fb9ef7e4c544a34a67a142782674

Please build it and try it again on your app. I am waiting for your response.

@saikrishna321
Copy link
Member

@TikhomirovSergey sure trying now ..

@saikrishna321
Copy link
Member

saikrishna321 commented Jan 2, 2017

@TikhomirovSergey Thanks it is working fine now :) can merge this .. will raise further issues if i get through with page objects

@TikhomirovSergey
Copy link
Contributor Author

@saikrishna321 Ok. I'm going to publish 5.0.0-BETA2 soon. For now you can use the built shapshot instead.

@TikhomirovSergey TikhomirovSergey merged commit a45dff7 into appium:master Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.