Update Page object tools to XCUIT mode#545
Merged
TikhomirovSergey merged 2 commits intoappium:masterappium/java-client:masterfrom Dec 27, 2016
TikhomirovSergey:xcuitFindByCopy head branch name to clipboard
Merged
Update Page object tools to XCUIT mode#545TikhomirovSergey merged 2 commits intoappium:masterappium/java-client:masterfrom TikhomirovSergey:xcuitFindByCopy head branch name to clipboard
TikhomirovSergey merged 2 commits intoappium:masterappium/java-client:masterfrom
TikhomirovSergey:xcuitFindByCopy head branch name to clipboard
Conversation
- new annotations were provided - supporting tools were actualized
2 tasks
|
|
||
| @Retention(RetentionPolicy.RUNTIME) @Target({ElementType.FIELD, ElementType.TYPE}) | ||
| @Repeatable(iOSXcuitFindBySet.class) | ||
| public @interface iOSXcuitFindBy { |
Member
There was a problem hiding this comment.
Can this be iOSXCUITFindBy please?
| import java.lang.annotation.Target; | ||
|
|
||
| @Retention(RetentionPolicy.RUNTIME) @Target({ElementType.FIELD, ElementType.TYPE}) | ||
| public @interface iOSXcuitFindBySet { |
Member
There was a problem hiding this comment.
Here too iOSXCUITFindBySet ?
SrinivasanTarget
requested changes
Dec 24, 2016
Member
SrinivasanTarget
left a comment
There was a problem hiding this comment.
Just naming conventions rest looks good to me.
| * @return an array of {@link io.appium.java_client.pagefactory.iOSXcuitFindBy} which builds a sequence of | ||
| * the chained searching for elements or a set of possible locators | ||
| */ | ||
| iOSXcuitFindBy[] value(); |
SrinivasanTarget
approved these changes
Dec 25, 2016
TikhomirovSergey
added a commit
that referenced
this pull request
Dec 27, 2016
…ndBy Addition to #545
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
io.appium.java_client.pagefactory.iOSXcuitFindBywas providedTypes of changes
Details
It was done because users still can need to support old automation (for iOS < 10) and xCuit mode for the same test scope.