#471 FIX#538
Merged
TikhomirovSergey merged 4 commits intoappium:masterappium/java-client:masterfrom Dec 17, 2016
TikhomirovSergey:masterCopy head branch name to clipboard
Merged
#471 FIX#538TikhomirovSergey merged 4 commits intoappium:masterappium/java-client:masterfrom TikhomirovSergey:masterCopy head branch name to clipboard
TikhomirovSergey merged 4 commits intoappium:masterappium/java-client:masterfrom
TikhomirovSergey:masterCopy head branch name to clipboard
Conversation
- WindowsDriver was designed - WindowsElement was designed - WindowsKeyCode was added - Page object tools were updated: - WindowsFindBy was added - AppiumFieldDecorator and supporting tools were actualized Additional change: All constructors declared by AppiumDriver are public now.
Contributor
Author
|
ping @SrinivasanTarget |
| String contextName = | ||
| String.valueOf(execute(DriverCommand.GET_CURRENT_CONTEXT_HANDLE).getValue()); | ||
| if (contextName.equals("null")) { | ||
| if ("null".equalsIgnoreCase(String.valueOf(contextName))) { |
Member
There was a problem hiding this comment.
Cant this be done using java Optional class?
Member
There was a problem hiding this comment.
contextName is already a string right then why are we using valueof() again?
SrinivasanTarget
approved these changes
Dec 16, 2016
Member
SrinivasanTarget
left a comment
There was a problem hiding this comment.
just few questions but LGTM 👍
yodurr
reviewed
Dec 16, 2016
| ANDROID_UI_AUTOMATOR(MobilePlatform.ANDROID.toLowerCase(), AndroidElement.class), | ||
| IOS_UI_AUTOMATION(MobilePlatform.IOS.toLowerCase(), IOSElement.class); | ||
| IOS_UI_AUTOMATION(MobilePlatform.IOS.toLowerCase(), IOSElement.class), | ||
| WINDOwS(MobilePlatform.WINDOWS, WindowsElement.class); |
Contributor
Author
There was a problem hiding this comment.
Ok. Maybe it is excessive :)
There was a problem hiding this comment.
sorry, I mean why is it "WINDOwS" on line 40? Shouldn't it be all caps?
Contributor
Author
There was a problem hiding this comment.
Ok. I will improve that :)
yodurr
reviewed
Dec 16, 2016
|
|
||
| if (iOSFindByArray != null && iOSFindByArray.length == 1) { | ||
| return createBy(new Annotation[] {iOSFindByArray[0]}, HowToUseSelectors.USE_ONE); | ||
| return createBy(new Annotation[] {iOSFindByArray[0]}, HowToUseSelectors.USE_ONE); |
|
This work is great to see, thank you Sergey! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
WindowsDriverwas designedWindowsElementwas designedWindowsKeyCodewas addedWindowsFindBywas addedAppiumFieldDecoratorand supporting tools were actualizedAdditional change:
AppiumDriverare public now.Types of changes
#471 FIX
#530 FIX