Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Remove console output from AppiumDriverLocalService by default#483

Closed
Mygod wants to merge 2 commits intoappium:masterappium/java-client:masterfrom
Mygod:masterMygod/java-client:masterCopy head branch name to clipboard
Closed

Remove console output from AppiumDriverLocalService by default#483
Mygod wants to merge 2 commits intoappium:masterappium/java-client:masterfrom
Mygod:masterMygod/java-client:masterCopy head branch name to clipboard

Conversation

@Mygod
Copy link

@Mygod Mygod commented Oct 6, 2016

Change list

Remove console output from AppiumDriverLocalService by default.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Reason: I need to use System.out to print some less verbose output. And user can easily turn it back on by calling addOutPutStream.

However the other way around is hard. Here's what I'm currently using.

        try {
            streamField = AppiumDriverLocalService.class.getDeclaredField("stream");
            streamField.setAccessible(true);
            streamsField = Class.forName("io.appium.java_client.service.local.ListOutputStream")
                    .getDeclaredField("streams");
            streamsField.setAccessible(true);
        } catch (ClassNotFoundException | NoSuchFieldException e) {
            e.printStackTrace();
        }
        try {
            ((ArrayList<OutputStream>) streamsField.get(streamField.get(service))).clear(); // remove System.out logging
        } catch (IllegalAccessException e) {
            e.printStackTrace();
        }

@Mygod
Remove console output from AppiumDriverLocalService by default
d412686 
Reason: I need to use System.out to print some less verbose output. And users can easily turn it back on by calling addOutPutStream anyway.
@alexander-poulikakos
Copy link
Contributor

alexander-poulikakos commented Nov 24, 2016

I fully agree on this PR. We should not log to System.out by default.

@SrinivasanTarget
Copy link
Member

SrinivasanTarget commented Nov 28, 2016

@TikhomirovSergey ping

@jeangb
Copy link

jeangb commented Feb 16, 2017

Hi, this looks very interesting.
Any news on this ?

@jsf-clabot
Copy link

jsf-clabot commented Feb 20, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Mygod
Copy link
Author

Mygod commented Feb 20, 2017

@jeangb Meanwhile you can still use the workaround mentioned in the PR to get rid of the console output.

@jeangb
Copy link

jeangb commented Feb 20, 2017

Thank you @Mygod, in what class this workaround take place ?

@Mygod
Copy link
Author

Mygod commented Feb 20, 2017

@jeangb Just whenever you create a AppiumDriverLocalService, do this on that object.

@jeangb
Copy link

jeangb commented Feb 20, 2017

@Mygod great, thx

@selenUser
Copy link

selenUser commented Feb 20, 2017

@Mygod which type is streamField ? (which import should I do ?)

@Mygod
Copy link
Author

Mygod commented Feb 20, 2017

@selenUser

streamField = AppiumDriverLocalService.class.getDeclaredField("stream");

It's a Field in reflection. :)

@drapostolos
Copy link
Contributor

drapostolos commented Feb 20, 2017

Perhaps this can be merged to master and released? To avoid workarounds...

@jeangb
Copy link

jeangb commented Feb 20, 2017

Do you think it would be possible to redirect this stream to an other view that console, in Eclipse. For example this view could be called Server.

jeangb added a commit to element-hq/riot-automated-tests that referenced this pull request Feb 21, 2017
@jeangb
Stop displaying appium servers logs in the console.
73677dd 
- Workaround until this appium/java-client#483
@VenkateshPS
Copy link

VenkateshPS commented Jan 22, 2018

Thanks @Mygod the workaround saved me.

@mykola-mokhnach
Copy link
Contributor

mykola-mokhnach commented May 24, 2018

#909

@Prasannajnaeyulu
Copy link

Prasannajnaeyulu commented Jun 19, 2019

This is where one can find the workaround until the appium server with this changes is released
element-hq/riot-automated-tests@73677dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@Mygod @alexander-poulikakos @SrinivasanTarget @jeangb @jsf-clabot @selenUser @drapostolos @VenkateshPS @mykola-mokhnach @Prasannajnaeyulu
Morty Proxy This is a proxified and sanitized view of the page, visit original site.