Convenient access to commands#445
Merged
TikhomirovSergey merged 5 commits intoappium:masterappium/java-client:masterfrom Jul 29, 2016
TikhomirovSergey:convenient_commandsCopy head branch name to clipboard
Merged
Convenient access to commands#445TikhomirovSergey merged 5 commits intoappium:masterappium/java-client:masterfrom TikhomirovSergey:convenient_commandsCopy head branch name to clipboard
TikhomirovSergey merged 5 commits intoappium:masterappium/java-client:masterfrom
TikhomirovSergey:convenient_commandsCopy head branch name to clipboard
Conversation
Contributor
Author
|
@SrinivasanTarget @jlipps @philgreenyouilabs @pfoster-youitv @simongranger |
Member
|
@TikhomirovSergey Interesting. I like this PR 👍there are some remarks from @codacy-bot. I will review soon. |
Contributor
|
Looks to be about the same as what you showed me on your fork. I took that previous one and made use of it for our You.i Engine side of things and it worked really well. I liked how I could subclass AppiumDriver and import commands from various devices. This will really make cross platform commands easier to call. 👍 from me |
Contributor
Author
|
@SrinivasanTarget Issues were fixed. You are free to review it |
Member
|
@TikhomirovSergey LGTM 👍 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
CommandExecutionHelperAndroidMobileCommandHelperIOSMobileCommandHelperMobileCommand.commandRepositoryis mutable now. Additional commands could be defined viaMobileCommand.commandRepository.put(String, CommandInfo)there.Types of changes
Details
There are projects which based on Appium (modifications, additional customized automation layers and so on). In order to make client convenient these chandes were made:
MobileCommand.commandRepository.put(String, CommandInfo)