#242 fix#437
#242 fix#437TikhomirovSergey merged 8 commits intoappium:masterappium/java-client:masterfrom TikhomirovSergey:#242-fixCopy head branch name to clipboard
Conversation
Now it is needed to add the listenable objet factory and cover it with tests
|
@SrinivasanTarget @bootstraponline could you review this PR? @GiannisPapadakis @Simon-Kaz you are free to join the discussion :) There is a PR proposed to Selenium: SeleniumHQ/selenium#1034. |
|
@TikhomirovSergey I like this PR 👍 esp. WIKI. Will review my best soon :) |
|
@TikhomirovSergey Its nice to see @codacy-bot working in PR's. |
|
@SrinivasanTarget That cool. will fix code of tests soon. |
|
Is there a way to configure codacy-bot to stop complaining about particular kind of issue like in this PR ? |
|
@vikramvi why do anyone want to do that? This helps in quick code review and code quality right.. |
@vikramvi @saikrishna321 I'm and @SrinivasanTarget for clean code. I think is good. Soon we will use CI for the PR validation and it will complain about bugs or test errors. I think it is offtop. What do you think about the proposed PR? |
Also: - improvement of the WIKI chapter - update to org.springframework spring-context v4.3.1.RELEASE
|
@TikhomirovSergey Awesome Codacy is Green now 👍 |
It was found during the self-review.
|
@TikhomirovSergey Wow .. this is real kool feature and would help a lot in reporting. Thanks @TikhomirovSergey for working on this. |
Change list
org.springframework spring-context v4.3.1.RELEASEandorg.aspectj aspectjweaver v1.8.9Types of changes
Details
Motivation:
Is described at #242
Also there is no really new and interesting features since v3.1.0/v3.2.0