Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

added getSession api to fetch deviceUDID#403

Merged
SrinivasanTarget merged 3 commits intoappium:masterappium/java-client:masterfrom
saikrishna321:masterCopy head branch name to clipboard
Jun 8, 2016
Merged

added getSession api to fetch deviceUDID#403
SrinivasanTarget merged 3 commits intoappium:masterappium/java-client:masterfrom
saikrishna321:masterCopy head branch name to clipboard

Conversation

@saikrishna321
Copy link
Member

@saikrishna321 saikrishna321 commented Jun 6, 2016

Change list

This PR helps users to fetch the sessionDetails.

appium/appium#6550

#215

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Received response


  "status": 0,
  "value": {
    "platform": "LINUX",
    "webStorageEnabled": false,
    "takesScreenshot": true,
    "javascriptEnabled": true,
    "databaseEnabled": false,
    "networkConnectionEnabled": true,
    "locationContextEnabled": false,
    "warnings": {

    },
    "desired": {
      "app": "\/Users\/saikrisv\/git\/java-client\/java-client\/src\/test\/java\/io\/appium\/java_client\/IntentExample.apk",
      "platformName": "Android",
      "deviceName": "Android Emulator"
    },
    "app": "\/Users\/saikrisv\/git\/java-client\/java-client\/src\/test\/java\/io\/appium\/java_client\/IntentExample.apk",
    "platformName": "Android",
    "deviceName": "192.168.65.101:5555",
    "deviceUDID": "192.168.65.101:5555",
    "platformVersion": "5.0",
    "appPackage": "com.prgguru.android",
    "appWaitPackage": "com.prgguru.android",
    "appActivity": "com.prgguru.android.IntentExampleActivity",
    "appWaitActivity": "com.prgguru.android.IntentExampleActivity"
  },
  "sessionId": "0ac42e16-65c3-40ec-bcf0-fae7d9dd9a4a"
}

Sample Code:

java-client/src/test/java/io/appium/java_client/android/GetSessionDetailsTest.java

@saikrishna321
Copy link
Member Author

saikrishna321 commented Jun 6, 2016

@TikhomirovSergey @SrinivasanTarget Please review .

@email2vimalraj your welcome to review this.

@SrinivasanTarget SrinivasanTarget added this to the 4.1.0 milestone Jun 6, 2016
TikhomirovSergey
TikhomirovSergey reviewed Jun 6, 2016
View reviewed changes
src/test/java/io/appium/java_client/android/GetSessionDetailsTest.java Outdated
}


@Test public void getDeviceUDIDTest() {
Copy link
Contributor

@TikhomirovSergey TikhomirovSergey Jun 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this test class? Maybe it makes sense to add this method to https://github.com/appium/java-client/blob/master/src/test/java/io/appium/java_client/android/AndroidDriverTest.java. What do you think?

@TikhomirovSergey
Copy link
Contributor

TikhomirovSergey commented Jun 6, 2016

I'm ok. But there is the remark.

@saikrishna321
Copy link
Member Author

saikrishna321 commented Jun 6, 2016

Yup, makes sense to move it AndroidDriverTest .. will do that ....

@saikrishna321
Copy link
Member Author

saikrishna321 commented Jun 7, 2016

@TikhomirovSergey made changes as suggested .. Thoughts ?

@SrinivasanTarget
Copy link
Member

SrinivasanTarget commented Jun 7, 2016

@saikrishna321 I see AndroidDriverTest is broken. Can you add this line back https://github.com/appium/java-client/pull/403/files#diff-4cea3ff81e0a1323e7aeb653d2e4a366L30. Also squash your commits if possible.

@saikrishna321
Copy link
Member Author

saikrishna321 commented Jun 7, 2016

@SrinivasanTarget made the changes, sorry messed locally cant squash..

@email2vimalraj
Copy link
Contributor

email2vimalraj commented Jun 7, 2016

@saikrishna321 : I'm fine with the changes.

@TikhomirovSergey
Copy link
Contributor

TikhomirovSergey commented Jun 8, 2016

Ok. I'm merging it soon

@SrinivasanTarget SrinivasanTarget merged commit eb56807 into appium:master Jun 8, 2016
@SrinivasanTarget
Copy link
Member

SrinivasanTarget commented Jun 8, 2016

Merged @saikrishna321

@TikhomirovSergey TikhomirovSergey mentioned this pull request Jul 16, 2016
Merged
3 tasks
SrinivasanTarget added a commit that referenced this pull request Jul 18, 2016
@SrinivasanTarget
Merge pull request #441 from TikhomirovSergey/session-map-data
36f7dcf 
The complete #215 fix and addition to #403
pfoster-youitv pushed a commit to pfoster-youitv/appium-java-client that referenced this pull request Jul 29, 2016
@TikhomirovSergey @pfoster-youitv
The complete appium#215 fix and addition to appium#403
d99f18c 
The bug which has not been caught previously was worked out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@saikrishna321 @TikhomirovSergey @SrinivasanTarget @email2vimalraj
Morty Proxy This is a proxified and sanitized view of the page, visit original site.