Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

refactor!: Remove obsolete event firing decorators#1676

Merged
mykola-mokhnach merged 1 commit intoappium:masterappium/java-client:masterfrom
mykola-mokhnach:rm_springmykola-mokhnach/java-client:rm_springCopy head branch name to clipboard
Apr 4, 2022
Merged

refactor!: Remove obsolete event firing decorators#1676
mykola-mokhnach merged 1 commit intoappium:masterappium/java-client:masterfrom
mykola-mokhnach:rm_springmykola-mokhnach/java-client:rm_springCopy head branch name to clipboard

Conversation

@mykola-mokhnach
Copy link
Contributor

Change list

BREAKING CHANGES:

  • Removed previously deprecated legacy Spring-based event decorators in favour of the Selenium's built-in one

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@valfirst
Copy link
Collaborator

valfirst commented Apr 4, 2022

Does it make sense to add a note on breaking changes to the migration guide?

@mykola-mokhnach
Copy link
Contributor Author

Does it make sense to add a note on breaking changes to the migration guide?

It's already there. The related stuff has been already marked as deprecated and now it's time to remove it completely for good (and publish in the next minor lib version)

@mykola-mokhnach mykola-mokhnach merged commit 2102e3d into appium:master Apr 4, 2022
@mykola-mokhnach mykola-mokhnach deleted the rm_spring branch April 4, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.