build: relax constraints of Selenium dependencies versions#1606
Merged
valfirst merged 1 commit intomasterappium/java-client:masterfrom Dec 3, 2021
do-not-mark-selenium-dependencies-versions-as-strictappium/java-client:do-not-mark-selenium-dependencies-versions-as-strictCopy head branch name to clipboard
Merged
build: relax constraints of Selenium dependencies versions#1606valfirst merged 1 commit intomasterappium/java-client:masterfrom do-not-mark-selenium-dependencies-versions-as-strictappium/java-client:do-not-mark-selenium-dependencies-versions-as-strictCopy head branch name to clipboard
valfirst merged 1 commit intomasterappium/java-client:masterfrom
do-not-mark-selenium-dependencies-versions-as-strictappium/java-client:do-not-mark-selenium-dependencies-versions-as-strictCopy head branch name to clipboard
Conversation
SrinivasanTarget
approved these changes
Dec 3, 2021
Contributor
|
We could try that, although there were already issues about several breaking selenium API updates because of incompatible changes in their API. Basically the question is how big is the probability that the next selenium version (minor, major or patch) is going to be incompatible to the current Appium client. And from my perspective such probability could be pretty high, since we don't only use public APIs, but rather perform many reflective calls to private/protected stuff and hack selenium lib here and there. |
Contributor
|
Maybe for now we could declare a strict version range like in https://docs.gradle.org/current/userguide/single_versions.html (Example 2): |
7af7ff8 to
ac02157
Compare
Collaborator
Author
|
@mykola-mokhnach thank you for your comments, I really appreciate them, I've updated the PR following your hints |
ac02157 to
06fedd1
Compare
mykola-mokhnach
approved these changes
Dec 3, 2021
https://docs.gradle.org/current/userguide/dependency_downgrade_and_exclude.html: "conflicting strict dependencies will trigger a build failure that you have to resolve". An attempt to use `java-client:8.0.0-beta` in conjunction with Selenium 4.1.0 leads to build failures, like: ``` > Could not resolve org.seleniumhq.selenium:selenium-remote-driver:{strictly 4.0.0}. Required by: project :xxxxxxx > io.appium:java-client:8.0.0-beta ``` In a favor of flexibility the constraints of selenium dependencies versions are relaxed.
06fedd1 to
bc72fec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
In a favor of flexibility the constraints of selenium dependencies versions are relaxed.
Types of changes
What types of changes are you proposing/introducing to Java client?
Details
https://docs.gradle.org/current/userguide/dependency_downgrade_and_exclude.html: "conflicting strict dependencies will trigger a build failure that you have to resolve".
An attempt to use
java-client:8.0.0-betain conjunction with Selenium 4.1.0 leads to build failures, like:In a favor of flexibility the constraints of selenium dependencies versions are relaxed.