fix: Parse platformName if it is passed as enum item#1369
Merged
mykola-mokhnach merged 6 commits intoappium:masterappium/java-client:masterfrom Jul 9, 2020
Merged
fix: Parse platformName if it is passed as enum item#1369mykola-mokhnach merged 6 commits intoappium:masterappium/java-client:masterfrom
mykola-mokhnach merged 6 commits intoappium:masterappium/java-client:masterfrom
Conversation
KazuCocoa
approved these changes
Jul 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Related to #1275
Types of changes
Details
I don't know the reason why to pass enum value instead of a string as platformName, like this is required by the standard, but whatever. The fix should just make it working for both cases.