Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Adding working tap method for webView context#119

Closed
vs-dev-bg wants to merge 4 commits intoappium:masterappium/java-client:masterfrom
vs-dev-bg:mastervs-dev-bg/java-client:masterCopy head branch name to clipboard
Closed

Adding working tap method for webView context#119
vs-dev-bg wants to merge 4 commits intoappium:masterappium/java-client:masterfrom
vs-dev-bg:mastervs-dev-bg/java-client:masterCopy head branch name to clipboard

Conversation

@vs-dev-bg
Copy link

New working tapmethod according to JSON Wire Protocol. Because current version of chromedriver is not able to process 'touch/perform' url. Ohter tap methods don't work properly in webview context (hybrid app), click() method of web element also doesn't work. Because of this new tap method is extremely needed.

Add tapElement method with correct JSON Wire Protocol
Add TOUCH_SINGLE_TAP command with correct value according to JSON Wire Protocol.
@vs-dev-bg vs-dev-bg changed the title Adding working tap method for this client Adding working tap method for java client Oct 8, 2014
@TikhomirovSergey
Copy link
Contributor

Hello, @vs-dev-bg!
Could you please declare your method to TouchShortcuts.java interface?

@TikhomirovSergey
Copy link
Contributor

I think it would be better to rename this method to

public void tap(WebElement element)

@vs-dev-bg
Copy link
Author

Okay I'll rename method to tap and also I'll add method to
TouchShortcuts.java

On Wed, Oct 8, 2014 at 2:01 PM, Sergey Tikhomirov notifications@github.com
wrote:

I think it would be better to rename this method to

public void tap(WebElement element)


Reply to this email directly or view it on GitHub
#119 (comment).

@TikhomirovSergey
Copy link
Contributor

👍

@vs-dev-bg vs-dev-bg changed the title Adding working tap method for java client Adding working tap method for webView context Oct 8, 2014
@Jonahss
Copy link
Member

Jonahss commented Oct 8, 2014

This method is already implemented as part of the selenium RemoteWebDriver and I don't want to re-implement it here unless we have to. Couldn't you use an @Augment annotation to add SwipableWebBrowser or RemoteTouchScreen? Then use this method?

@vs-dev-bg
Copy link
Author

Okay you're right. Ignore this pull request ;)

@Jonahss
Copy link
Member

Jonahss commented Oct 9, 2014

I wish it could be more convenient or easy though ;)

The selenium WebDriver java client is pretty confusing and clunky. Would you consider working on a flatter and simplified version? I've gotten feedback that the java-client isn't as nice as some people hope.

@Jonahss Jonahss closed this Oct 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.