Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add the missing settings which introduced in appium 1.12 and 1.13#1156

Merged
mykola-mokhnach merged 1 commit intoappium:masterappium/java-client:masterfrom
takeyaqa:add_missing_settingsCopy head branch name to clipboard
Jun 14, 2019
Merged

Add the missing settings which introduced in appium 1.12 and 1.13#1156
mykola-mokhnach merged 1 commit intoappium:masterappium/java-client:masterfrom
takeyaqa:add_missing_settingsCopy head branch name to clipboard

Conversation

@takeyaqa
Copy link

Change list

  • add the missing settings which introduced in appium 1.12 and 1.13
    • shutdownOnPowerDisconnect
    • mjpegScalingFactor
    • autoUpdateImageElementPosition
    • fixImageTemplateScale
    • defaultImageTemplateScale
  • fix javadocs
    • use https
    • fix wrong default values
  • add tests

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

* add the missing setting which introduced in appium 1.12 and 1.13
* fix javadoc
* add test
@mykola-mokhnach
Copy link
Contributor

thanks

@mykola-mokhnach mykola-mokhnach merged commit 1aac740 into appium:master Jun 14, 2019
@takeyaqa takeyaqa deleted the add_missing_settings branch June 14, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.