Delete deprecated methods#1077
Merged
SrinivasanTarget merged 3 commits intoappium:masterappium/java-client:masterfrom Dec 28, 2018
Merged
Delete deprecated methods#1077SrinivasanTarget merged 3 commits intoappium:masterappium/java-client:masterfrom
SrinivasanTarget merged 3 commits intoappium:masterappium/java-client:masterfrom
Conversation
| @@ -166,27 +166,17 @@ protected By buildMobileNativeBy() { | ||
| Optional<HowToUseLocators> howToUseLocatorsOptional = ofNullable(howToUseLocators); | ||
|
|
||
| By result = null; |
Contributor
There was a problem hiding this comment.
is this variable still used?
Member
Author
There was a problem hiding this comment.
Nope, it's not used, have deleted it now.
Contributor
|
It also makes sense to check the failing job on Azure CI: https://dev.azure.com/srinivasansekar/java-client/_build/results?buildId=74 |
Contributor
|
Checkstyle is still not very happy |
mykola-mokhnach
approved these changes
Dec 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Delete deprecated methods
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that apply