Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

MQ37
Copy link
Collaborator

@MQ37 MQ37 commented Aug 28, 2025

No description provided.

@MQ37 MQ37 requested a review from jancurn August 28, 2025 11:40
"title": "Claude Desktop",
"url": "https://claude.ai/download",
"protocolVersion": "2024-11-05",
"claude-ai": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls can we keep these in alphabetical order? Maybe the npm build script could reshuffle the file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets run that in check.yml workflow and if the clients are not sorted it will fail and user will need to run npm run sort locally and commit the correctly sorted version. I think we can somehow block the merge unless it is sorted.

we strongly recommend the MCP clients to use a new client name to avoid confusing the servers
and provide the best user and agent experience.

### Clients supported
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting - how about we generate this table from the JSON file automatically using the build command? I'd keep the same columns as https://modelcontextprotocol.io/clients#feature-support-matrix

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we have a sufficient coverage, I think they might adopt our package too rather than having to maintain the table themselves

Copy link
Collaborator Author

@MQ37 MQ37 Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done - we are using the npm run generate-table

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add this to the PR body template checklist and run that on release when updating changelog.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets just keep that in the check workflow that runs on each PR (it will fail if not updated) - that will be simpler

@MQ37 MQ37 requested a review from jancurn August 28, 2025 13:24
@MQ37 MQ37 merged commit 9203d5c into master Aug 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.