Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: Reduce flakiness of test_timeout_in_handler in CI #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 11, 2025
Merged

chore: Reduce flakiness of test_timeout_in_handler in CI #1243

merged 4 commits into from
Jun 11, 2025

Conversation

Pijukatel
Copy link
Collaborator

@Pijukatel Pijukatel commented Jun 11, 2025 •
edited
Loading

Description

Add marker run_alone for running tests in isolation as well.
Add the marker test_timeout_in_handler to ensure it has enough resources.

@Pijukatel Pijukatel added adhoc Ad-hoc unplanned task added during the sprint. debt Code quality improvement or decrease of technical debt. labels Jun 11, 2025
@github-actions github-actions bot added this to the 116th sprint - Tooling team milestone Jun 11, 2025
@Pijukatel Pijukatel requested review from vdusek and Mantisus June 11, 2025 10:58
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Jun 11, 2025
@Pijukatel Pijukatel marked this pull request as ready for review June 11, 2025 11:08
Mantisus
Mantisus approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@Mantisus Mantisus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

janbuchar
janbuchar approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, this is one of the tests that could benefit from some event-loop mocking that would make sleeps instant (something like https://vitest.dev/guide/mocking.html#timers). But take my "Approve" and go in peace (for now 😁)

vdusek
vdusek reviewed Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it in #1194, and it didn't help.

I would suggest either skipping this test for now and creating a follow-up issue, or - as we discussed on Slack - since the test passes when run in isolation (I ran it 100 times and it passed every time), let's look into running it in isolation somehow.

@Pijukatel Pijukatel force-pushed the fix_test_timeout_in_handler branch from 55096c1 to d44beb9 Compare June 11, 2025 12:03
@Pijukatel Pijukatel marked this pull request as draft June 11, 2025 12:17
@Pijukatel Pijukatel force-pushed the fix_test_timeout_in_handler branch from d44beb9 to 34d2636 Compare June 11, 2025 12:20
@Pijukatel Pijukatel requested a review from vdusek June 11, 2025 12:25
@Pijukatel Pijukatel marked this pull request as ready for review June 11, 2025 12:25
vdusek
vdusek approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try it

@Pijukatel Pijukatel merged commit c25a0a5 into master Jun 11, 2025
24 checks passed
@Pijukatel Pijukatel deleted the fix_test_timeout_in_handler branch June 11, 2025 12:49
@Pijukatel
Copy link
Collaborator Author

Honestly, this is one of the tests that could benefit from some event-loop mocking that would make sleeps instant (something like https://vitest.dev/guide/mocking.html#timers). But take my "Approve" and go in peace (for now 😁)

Yes, that would be the best. Unfortunately I could not find any well maintained existing solution for this in Python :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbuchar janbuchar janbuchar approved these changes

@vdusek vdusek vdusek approved these changes

@Mantisus Mantisus Mantisus approved these changes

Assignees

@Pijukatel Pijukatel

Labels
adhoc Ad-hoc unplanned task added during the sprint. debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
116th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
4 participants
@Pijukatel @janbuchar @vdusek @Mantisus
Morty Proxy This is a proxified and sanitized view of the page, visit original site.