Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

EventManager improvements and unit tests #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 20, 2023
Merged

EventManager improvements and unit tests #72

merged 3 commits into from
Feb 20, 2023

Conversation

fnesveda
Copy link
Member

I've made two improvements to EventManager:

  • it now waits for the platform events websocket connection during initialization (before, if it could not connect to the websocket, it would initialize without errors, and then raise an error immediately after)
  • it now accepts floats as the timeout when waiting for event listeners to complete

I've also written unit tests for it, since we didn't have it tested yet and this was the third time I found some bug in it, which the tests would catch if we had them.

@fnesveda fnesveda added t-core-services Issues with this label are in the ownership of the core services team. adhoc Ad-hoc unplanned task added during the sprint. labels Feb 17, 2023
@fnesveda fnesveda added this to the 57th sprint - Platform team milestone Feb 17, 2023
@fnesveda fnesveda self-assigned this Feb 17, 2023
Base automatically changed from chore/add-unit-tests-for-config-and-consts to master February 20, 2023 14:27
@fnesveda fnesveda merged commit 75454ca into master Feb 20, 2023
@fnesveda fnesveda deleted the feature/event-manager-improvements-and-tests branch February 20, 2023 15:59
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirimoravcik jirimoravcik jirimoravcik approved these changes

@drobnikj drobnikj drobnikj approved these changes

Assignees

@fnesveda fnesveda

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-core-services Issues with this label are in the ownership of the core services team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
57th sprint - Platform team
Development

Successfully merging this pull request may close these issues.
3 participants
@fnesveda @jirimoravcik @drobnikj
Morty Proxy This is a proxified and sanitized view of the page, visit original site.