feat: Expose logger argument on Actor.call to control log redirection from started Actor run
#487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Wait for apify api new release
Pijukatel
commented
Jun 18, 2025
| @@ -38,7 +38,8 @@ def prepare_test_env(monkeypatch: pytest.MonkeyPatch, tmp_path: Path) -> Callabl | ||
| """ | ||
|
|
||
| def _prepare_test_env() -> None: | ||
| delattr(apify._actor.Actor, '__wrapped__') | ||
| if hasattr(apify._actor.Actor, '__wrapped__'): |
There was a problem hiding this comment.
This is very mysterious. Why did the previous implementation work on older Python versions and not in new ones (sometimes)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
loggerargument is used to either disable log redirection, use the default redirection logger or to pass custom logger that will process the redirected logs from started Actor run.Issues
Related: apify/apify-client-js#632