Hi @honzajavorek, what were your suggestions for utilizing the Scrapy's get_project_settings?

Named the option call_exit (instead of exit) to avoid shadowing Python's built-in names.

Is this really necessary? I would rather keep the same naming as in the JS version. I recall this argument from another PR, where @janbuchar disagreed with the shadowing being necessary?

Is this really necessary? I would rather keep the same naming as in the JS version. I recall this argument from another PR, where @janbuchar disagreed with the shadowing being necessary?

Not strictly necessary, just good practice and keeping the linter happy. However, the built-in exit is primarily for interactive use, so it's not that big deal, and keeping argument names consistent is a good argument (although the Actor interfaces differ quite a lot just because of the context managers in Python). Any thoughts, @Pijukatel? Honza is already tagged.

Is this really necessary? I would rather keep the same naming as in the JS version. I recall this argument from another PR, where @janbuchar disagreed with the shadowing being necessary?

Not strictly necessary, just good practice and keeping the linter happy. However, the built-in exit is primarily for interactive use, so it's not that big deal, and keeping argument names consistent is a good argument (although the Actor interfaces differ quite a lot just because of the context managers in Python). Any thoughts, @Pijukatel? Honza is already tagged.

I am leaning towards call_exit as it is still quite similar to JS version, only adapted to Python world, but I do not have strong opinion about this and I am quite ok with also having exit + ignore.

Is this really necessary? I would rather keep the same naming as in the JS version. I recall this argument from another PR, where @janbuchar disagreed with the shadowing being necessary?

Not strictly necessary, just good practice and keeping the linter happy. However, the built-in exit is primarily for interactive use, so it's not that big deal, and keeping argument names consistent is a good argument (although the Actor interfaces differ quite a lot just because of the context managers in Python). Any thoughts, @Pijukatel? Honza is already tagged.

In general, I'm pro-shadowing and will always argue in favor of shadowing obscure Python builtins 😁 However, exit on its own is not exactly self-explanatory as a parameter name. call_exit might work better, but I feel that an even better name exists... Something like exit_process maybe?

I can't help myself, but the call_ prefix sounds really weird to me.

I have no problem changing to e.g. exit_process as was suggested.

Let's go with exit_process, that sounds much better.

LGTM.

My idea was to use get_project_settings() instead of checking the env var, because checking one env var isn't sufficient to detect we're inside a Scrapy project. But I didn't experiment with get_project_settings() enough to see whether it has side effects, or whether it's actually possible to easily distinguish settings created from a project and from a "no project".

This change detects Scrapy by checking whether it's installed, which might not be perfect (perhaps I could use something from Scrapy, but not the whole thing? how many scrapers like that exists? probably not many 🤔 ), but the most important change is that if I realize the SDK doesn't do a great job in detecting my particular use case, I can now explicitly say "please do not call sys.exit()", no bizarre hacks needed. Thanks!

This closes #389 as well.

Thanks, @honzajavorek. I tried using get_project_settings, but I didn't find anything useful for detecting a Scrapy project there. So I stayed with simply trying to import the scrapy package. This can lead to false positives, of course, but it's probably still improvement over the current approach.