Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: update to Crawlee v0.6 #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2025
Merged

feat: update to Crawlee v0.6 #420

merged 3 commits into from
Mar 4, 2025

Conversation

vdusek
Copy link
Contributor

@vdusek vdusek commented Mar 3, 2025

I use "feat", I believe it is correct to release this as minor version (not patch).

@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Mar 3, 2025
@vdusek vdusek added this to the 109th sprint - Tooling team milestone Mar 3, 2025
@vdusek vdusek requested review from Mantisus and Pijukatel March 3, 2025 16:53
@vdusek vdusek self-assigned this Mar 3, 2025
Pijukatel
Pijukatel reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@Pijukatel Pijukatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you will need to either add

    ignored_env_vars = {
        ApifyEnvVars.XVFB,
        ApifyEnvVars.CHROME_EXECUTABLE_PATH
...

to test_get_env_with_randomized_env_vars

or remove those variables from apify-shared (probably not)

@vdusek vdusek requested a review from Pijukatel March 4, 2025 09:03
@vdusek
Copy link
Contributor Author

vdusek commented Mar 4, 2025

I removed them from the apify-shared and released a new version (it's used only here and in client).

@vdusek vdusek added the adhoc Ad-hoc unplanned task added during the sprint. label Mar 4, 2025
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Mar 4, 2025
@vdusek vdusek merged commit 9be4336 into master Mar 4, 2025
27 checks passed
@vdusek vdusek deleted the use-crawlee-v06 branch March 4, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pijukatel Pijukatel Pijukatel approved these changes

@Mantisus Mantisus Awaiting requested review from Mantisus

Assignees

@vdusek vdusek

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
109th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@vdusek @Pijukatel
Morty Proxy This is a proxified and sanitized view of the page, visit original site.