Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: add rate_limit_errors property for ApifyStorageClient #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 12, 2025

Conversation

Mantisus
Copy link
Collaborator

@Mantisus Mantisus commented Feb 4, 2025

Description

  • add rate_limit_errors property for ApifyStorageClient.

Issues

@Mantisus
Copy link
Collaborator Author

Mantisus commented Feb 4, 2025

Note to self. Don't forget to upgrade apify-client from beta to stable before merge

@Mantisus Mantisus marked this pull request as ready for review February 7, 2025 13:48
@Mantisus Mantisus had a problem deploying to fork-pr-integration-tests February 7, 2025 14:01 — with GitHub Actions Failure
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just not sure whether the chore is right type, @janbuchar?

@janbuchar
Copy link
Contributor

janbuchar commented Feb 7, 2025

Please refrain from merging this until apify/crawlee-python#957 (comment) is resolved.

LGTM, just not sure whether the chore is right type, @janbuchar?

I guess we could shoehorn it into chore(deps)? The downside is that chores do not trigger version bumps.

@Mantisus Mantisus had a problem deploying to fork-pr-integration-tests February 10, 2025 14:46 — with GitHub Actions Failure
@Mantisus Mantisus changed the title chore: add rate_limit_errors property for ApifyStorageClient chore(deps): add rate_limit_errors property for ApifyStorageClient Feb 10, 2025
@Mantisus
Copy link
Collaborator Author

Since apify/crawlee-python#957 resolved. I suggest that re-check this PR.

Maybe someone will have some thoughts for a better type for PR.

@vdusek vdusek changed the title chore(deps): add rate_limit_errors property for ApifyStorageClient feat: add rate_limit_errors property for ApifyStorageClient Feb 12, 2025
@vdusek vdusek merged commit 89c230a into apify:master Feb 12, 2025
24 of 25 checks passed
@vdusek vdusek had a problem deploying to fork-pr-integration-tests February 13, 2025 09:17 — with GitHub Actions Error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gather statistics on HTTP rate limit errors
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.