Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: use HttpHeaders type in Scrapy integration #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 15, 2024
Merged

fix: use HttpHeaders type in Scrapy integration #289

merged 5 commits into from
Oct 15, 2024

Conversation

vdusek
Copy link
Contributor

@vdusek vdusek commented Oct 10, 2024 •
edited
Loading

  • Use HttpHeaders type in Scrapy integration (and fix tests)
  • Make Configuration.standby_url field optional (and fix tests)
  • Add asyncio_default_fixture_loop_scope to Pytest options
  • Rm tests from pre-commit

@vdusek vdusek added bug Something isn't working. adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Oct 10, 2024
@vdusek vdusek added this to the 100th sprint - Tooling team milestone Oct 10, 2024
@vdusek vdusek requested a review from janbuchar October 10, 2024 11:02
@vdusek vdusek self-assigned this Oct 10, 2024
janbuchar
janbuchar approved these changes Oct 10, 2024
View reviewed changes
src/apify/scrapy/requests.py Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Oct 10, 2024
janbuchar
janbuchar reviewed Oct 10, 2024
View reviewed changes
src/apify/_configuration.py Outdated Show resolved Hide resolved
@vdusek vdusek merged commit 3e33e91 into master Oct 15, 2024
19 checks passed
@vdusek vdusek deleted the fix-scrapy-http-headers branch October 15, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbuchar janbuchar janbuchar approved these changes

Assignees

@vdusek vdusek

Labels
adhoc Ad-hoc unplanned task added during the sprint. bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
100th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@vdusek @janbuchar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.