Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: add standby URL, change default standby port #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 9, 2024
Merged

feat: add standby URL, change default standby port #287

merged 3 commits into from
Oct 9, 2024

Conversation

jirimoravcik
Copy link
Member

This PR introduces a new environment variable with standby URL, it also changes the default port for the standby port env var.

@github-actions github-actions bot added this to the 100th sprint - Platform Team milestone Oct 8, 2024
@github-actions github-actions bot added the t-core-services Issues with this label are in the ownership of the platform team. label Oct 8, 2024
@janbuchar
Copy link
Contributor

Cool. What's the relationship between this and web_server_url or container_url?

@jirimoravcik
Copy link
Member Author

jirimoravcik commented Oct 8, 2024 •
edited
Loading

Cool. What's the relationship between this and web_server_url or container_url?

web_server_url == container_url, these are unique for each run (they look something like https://someidhere.runs.apify.net/). Standby URL is the nice generic, e.g. https://super-scraper-api.apify.actor, which does automatic load balancing and scaling.

@janbuchar
Copy link
Contributor

Cool. What's the relationship between this and web_server_url or container_url?

web_server_url == container_url, these are unique for each run (they look something like https://someidhere.runs.apify.net/). Standby URL is the nice generic, e.g. https://super-scraper-api.apify.actor, which does automatic load balancing and scaling.

Understood, thanks. Could you mention the different in the field description please? And maybe update https://docs.apify.com/platform/actors/development/programming-interface/environment-variables as well?

@jirimoravcik
Copy link
Member Author

Cool. What's the relationship between this and web_server_url or container_url?

web_server_url == container_url, these are unique for each run (they look something like https://someidhere.runs.apify.net/). Standby URL is the nice generic, e.g. https://super-scraper-api.apify.actor, which does automatic load balancing and scaling.

Understood, thanks. Could you mention the different in the field description please? And maybe update docs.apify.com/platform/actors/development/programming-interface/environment-variables as well?

I tried to improve the descriptions here.

I'm already preparing a PR for docs, but I want to mention the configs in SDKs, so that's why I'm doing it first.

fnesveda
fnesveda approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, just one small note

src/apify/_configuration.py Outdated Show resolved Hide resolved
@jirimoravcik @fnesveda
Update src/apify/_configuration.py
090d8c5 
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
@jirimoravcik jirimoravcik merged commit 8cd2f2c into master Oct 9, 2024
7 of 11 checks passed
@jirimoravcik jirimoravcik deleted the feat/add-standby-url-change-port branch October 9, 2024 09:50
vdusek
vdusek reviewed Oct 10, 2024
View reviewed changes
src/apify/_configuration.py
] = 4321

standby_url: Annotated[
str,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Crawlee, we use a custom URL validator function:

    url: Annotated[str, BeforeValidator(validate_http_url), Field(...)]

https://github.com/apify/crawlee-python/blob/v0.3.8/src/crawlee/_request.py#L112

@jirimoravcik Could we use the same approach here as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek left review comments

@janbuchar janbuchar janbuchar approved these changes

@fnesveda fnesveda fnesveda approved these changes

Assignees

@jirimoravcik jirimoravcik

Labels
t-core-services Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
100th sprint - Platform Team
Development

Successfully merging this pull request may close these issues.
4 participants
@jirimoravcik @janbuchar @fnesveda @vdusek
Morty Proxy This is a proxified and sanitized view of the page, visit original site.