fix: respect forceCloud in KeyValueStore.getPublicUrl() calls
#462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this works, it requires
|
|
Thanks for the fix @barjin! I believe that anything is fine as long as it works. We're going to overhaul the storage system in crawlee v4 anyways, so no need to overthink it now. |
janbuchar
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original check from #302 was not sufficient. When the user passes
forceCloud: truetoKVS.open(), the SDK instance points to a platform-backed KVS, even if the script is run locally.This PR proposes checking the runtime type of
KeyValueStore.client. If this is a client instance fromapify-client, we're communicating with the platform, regardless of the place of execution (Platform / locally).Closes #459