fix: prevent reboot loops #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
approved these changes
Dec 18, 2024
fnesveda
added a commit
to apify/apify-sdk-python
that referenced
this pull request
Dec 20, 2024
…oot behavior with JS SDK (#361) This fixes several issues with the `Actor.reboot()` behavior: - `Actor.reboot()` waits for all event handlers to finish, but if itself it was called in an event handler, it would be waiting for itself, getting into a deadlock - `Actor.reboot()` in the JS SDK triggers event handlers for the `migrating` and `persistState` events, but in the Python SDK it was triggering only the `persistState` handlers This aligns the behavior to work like the JS SDK, and prevents reboot getting into an infinite loop by allowing it to be called only once. Related PR in JS SDK: apify/apify-sdk-js#345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use
Actor.reboot()inside amigratingevent handler, because it internally calls all the handlers for themigratingevent, so calling that on themigratingevent would get into an infinite loop. This fixes it by allowing the reboot to be called only once.