Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: add standby port to configuration #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2024
Merged

feat: add standby port to configuration #310

merged 2 commits into from
Jul 4, 2024

Conversation

jirimoravcik
Copy link
Member

This PR adds Actor Standby port to the configuration.

@jirimoravcik jirimoravcik added the adhoc Ad-hoc unplanned task added during the sprint. label Jul 4, 2024
@jirimoravcik jirimoravcik requested review from B4nan and fnesveda July 4, 2024 12:19
@github-actions github-actions bot added this to the 93rd sprint - Platform Team milestone Jul 4, 2024
@github-actions github-actions bot added the t-core-services Issues with this label are in the ownership of the core services team. label Jul 4, 2024
B4nan
B4nan approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit but i don't mind merging as is

packages/apify/src/configuration.ts Outdated Show resolved Hide resolved
@jirimoravcik @B4nan
Update packages/apify/src/configuration.ts
d8f8032 
Co-authored-by: Martin Adámek <banan23@gmail.com>
@jirimoravcik jirimoravcik merged commit cc26098 into master Jul 4, 2024
@jirimoravcik jirimoravcik deleted the feature/add-standby-port-to-configuration branch July 4, 2024 12:41
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@B4nan B4nan B4nan approved these changes

@fnesveda fnesveda fnesveda approved these changes

Assignees

@jirimoravcik jirimoravcik

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-core-services Issues with this label are in the ownership of the core services team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.

Projects

None yet

Milestone

93rd sprint - Platform Team

Development

Successfully merging this pull request may close these issues.

3 participants

@jirimoravcik @B4nan @fnesveda
Morty Proxy This is a proxified and sanitized view of the page, visit original site.