Add Symfony Uid support #3715
Merged
Add Symfony Uid support #3715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
norkunas
commented
Sep 10, 2020
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tickets | fixes #3714 |
| License | MIT |
| Doc PR | api-platform/docs#... |
- Added support for denormalizing identifiers with symfony uuid/ulid;
- Added ulid/uuid support to json schema;
b06aa3b to
88b9bb5
Compare
8ff7e03 to
b49a163
Compare
b49a163 to
7ba124a
Compare
|
Thanks a lot @norkunas! |
|
See also: symfony/symfony#36406. |
maxhelias
reviewed
Sep 11, 2020
| xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | ||
|
|
||
| <services> | ||
| <service id="api_platform.identifier.symfony_ulid_normalizer" class="ApiPlatform\Core\Bridge\Symfony\Identifier\Normalizer\UlidNormalizer" public="false"> |
There was a problem hiding this comment.
Why not make the two Normalizers in one?
Like this : https://github.com/symfony/symfony/blob/dafcc58e6bd8553a6f461ff585322206ffd81956/src/Symfony/Component/Serializer/Normalizer/UidNormalizer.php#L40-L55
Wyze5280
approved these changes
Jul 22, 2022
| @@ -53,6 +53,7 @@ | ||
| use Symfony\Component\Finder\Finder; | ||
| use Symfony\Component\HttpClient\HttpClientTrait; | ||
| use Symfony\Component\HttpKernel\DependencyInjection\Extension; | ||
| use Symfony\Component\Uid\AbstractUid; | ||
| use Symfony\Component\Validator\Validator\ValidatorInterface; |
There was a problem hiding this comment.
Suggested change
| use Symfony\Component\Validator\Validator\ValidatorInterface; | |
| use Symfony\Component\Validator\Validator\ValidatorInterface; |
| @@ -53,6 +53,7 @@ | ||
| use Symfony\Component\Finder\Finder; | ||
| use Symfony\Component\HttpClient\HttpClientTrait; | ||
| use Symfony\Component\HttpKernel\DependencyInjection\Extension; | ||
| use Symfony\Component\Uid\AbstractUid; | ||
| use Symfony\Component\Validator\Validator\ValidatorInterface; | ||
| use Symfony\Component\Yaml\Yaml; |
There was a problem hiding this comment.
Suggested change
| use Symfony\Component\Yaml\Yaml; | |
| use Symfony\Component\Yaml\Yaml; |
| @@ -113,6 +113,8 @@ jobs: | ||
| run: | | ||
| composer global require --prefer-dist --no-progress --no-suggest --ansi \ |
There was a problem hiding this comment.
Suggested change
| composer global require --prefer-dist --no-progress --no-suggest --ansi \ | |
| composer global require --prefer-dist --no-progress --no-suggest --ansi \ |
| @@ -53,6 +53,7 @@ | ||
| use Symfony\Component\Finder\Finder; |
There was a problem hiding this comment.
Suggested change
| use Symfony\Component\Finder\Finder; | |
| use Symfony\Component\Finder\Finder; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.