Fix/2.0 tests #1183
Fix/2.0 tests #1183
Conversation
soyuka
commented
Jun 16, 2017
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | na |
| License | MIT |
| Doc PR | na |
| @@ -32,7 +32,7 @@ | ||
| protected function extractPath(string $path) | ||
| { | ||
| try { | ||
| $resourcesYaml = Yaml::parse(file_get_contents($path)); | ||
| $resourcesYaml = Yaml::parse(file_get_contents($path), Yaml::PARSE_KEYS_AS_STRINGS); |
There was a problem hiding this comment.
Not sure about this one, @meyerbaptiste is this correct? Thanks!
There was a problem hiding this comment.
Yes it's correct, but this constant was introduced in symfony/yaml 3.3. So tests will fail with the --prefer-lowest argument!
There was a problem hiding this comment.
Hmm, what solution do we have if we want tests to pass on 2.0 then?
There was a problem hiding this comment.
I could mark tests as legacy but doesn't feel clean enough.
There was a problem hiding this comment.
IIRC, using this constant is deprecated, the user should use quotes instead.
There was a problem hiding this comment.
hmm okay maybe I need to fix yaml files instead then.
There was a problem hiding this comment.
IIRC, using this constant is deprecated
Are you sure? I can't find any information about this subject and I don't see anything in the code of the component.
There was a problem hiding this comment.
Anyway, fixing the actual issue in the yaml seems to be the way to go.
There was a problem hiding this comment.
ab35851 to
5ae8472
Compare
| @@ -32,7 +32,7 @@ resources: | ||
| attributes: | ||
| 'foo': ['Foo'] | ||
| 'bar': | ||
| 0: ['Bar'] | ||
| '0': ['Bar'] |
Fix/2.0 tests