Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

modify plugin.dest.dir property #746

Merged
wu-sheng merged 1 commit intoapache:mainapache/skywalking-java:mainfrom
JoeCqupt:mainJoeCqupt/skywalking-java:mainCopy head branch name to clipboard
Jan 10, 2025
Merged

modify plugin.dest.dir property #746
wu-sheng merged 1 commit intoapache:mainapache/skywalking-java:mainfrom
JoeCqupt:mainJoeCqupt/skywalking-java:mainCopy head branch name to clipboard

Conversation

@JoeCqupt
Copy link
Contributor

@JoeCqupt JoeCqupt commented Jan 9, 2025

use ${maven.multiModuleProjectDirectory} to locate plugins dir

<plugin.dest.dir>${maven.multiModuleProjectDirectory}/skywalking-agent/plugins</plugin.dest.dir>

replace previously defined properties

<sdk.plugin.related.dir />
<agent.package.dest.dir>${project.build.directory}${sdk.plugin.related.dir}/../../../../skywalking-agent
</agent.package.dest.dir>
<plugin.dest.dir>${agent.package.dest.dir}/plugins</plugin.dest.dir>

especially,we can avoid the annoying sdk.plugin.related.dir property

the same to bootstrap.plugin.dest.dir expired.plugin.dest.dir optional.plugin.dest.dir optional.reporter.plugins.dest.dir

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wu-sheng wu-sheng added the enhancement New feature or request label Jan 10, 2025
@wu-sheng wu-sheng added this to the 9.4.0 milestone Jan 10, 2025
@wu-sheng wu-sheng merged commit 31bf638 into apache:main Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.