Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Upgrade nats plugin to support 2.16.5#711

Merged
wu-sheng merged 6 commits intoapache:mainapache/skywalking-java:mainfrom
pg-yang:nats-patchpg-yang/skywalking-java:nats-patchCopy head branch name to clipboard
Jul 27, 2024
Merged

Upgrade nats plugin to support 2.16.5#711
wu-sheng merged 6 commits intoapache:mainapache/skywalking-java:mainfrom
pg-yang:nats-patchpg-yang/skywalking-java:nats-patchCopy head branch name to clipboard

Conversation

@pg-yang
Copy link
Member

@pg-yang pg-yang commented Jul 27, 2024

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

Support nats 2.16.5.
There is still no proper method and opportunity to change the message header and re-calculate the message length. From what I tested recently, up to 2.16.5 works correctly.

@wu-sheng
Copy link
Member

Please fix CI. You changed the plugin name.
And document(supported list) should be update.

More important, you need to add new version to test scenarios.

@wu-sheng wu-sheng added this to the 9.4.0 milestone Jul 27, 2024
@wu-sheng wu-sheng added enhancement New feature or request plugin labels Jul 27, 2024
@wu-sheng wu-sheng merged commit 24ec663 into apache:main Jul 27, 2024
@pg-yang pg-yang deleted the nats-patch branch July 28, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.