Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix the opentracing toolkit SPI config#696

Merged
wu-sheng merged 2 commits intoapache:mainapache/skywalking-java:mainfrom
xiaqi1210:mainCopy head branch name to clipboard
Jun 6, 2024
Merged

Fix the opentracing toolkit SPI config#696
wu-sheng merged 2 commits intoapache:mainapache/skywalking-java:mainfrom
xiaqi1210:mainCopy head branch name to clipboard

Conversation

@xiaqi1210
Copy link
Contributor

Fix

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.
  1. The directory for SPI should be /META-INF/services, not /META-INF.services.
  2. There is an issue with the letter casing in the class name. It should be SkywalkingTracer, not SkyWalkingTracer.

@wu-sheng wu-sheng added this to the 9.3.0 milestone Jun 6, 2024
@wu-sheng wu-sheng added the bug Something isn't working label Jun 6, 2024
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK to merge, but, OT is archived over 2 years(since January 31, 2022).

It is the time to get rid of it.

@wu-sheng wu-sheng merged commit 3a96458 into apache:main Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.