Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x#691

Merged
wu-sheng merged 3 commits intoapache:mainapache/skywalking-java:mainfrom
CzyerChen:fix/spring_schedulingCzyerChen/skywalking-java:fix/spring_schedulingCopy head branch name to clipboard
May 14, 2024
Merged

Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x#691
wu-sheng merged 3 commits intoapache:mainapache/skywalking-java:mainfrom
CzyerChen:fix/spring_schedulingCzyerChen/skywalking-java:fix/spring_schedulingCopy head branch name to clipboard

Conversation

@CzyerChen
Copy link
Contributor

@CzyerChen CzyerChen commented May 13, 2024

Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.

Since Spring 6.1.x, the intercepted method deprecated

  @Deprecated(
        since = "6.1"
    )
    @Nullable
    protected Runnable createRunnable(Object target, Method method) {
        return null;
    }

use the constructor method instead:

  public ScheduledMethodRunnable(Object target, Method method, @Nullable String qualifier, Supplier<ObservationRegistry> observationRegistrySupplier) {
        this.target = target;
        this.method = method;
        this.qualifier = qualifier;
        this.observationRegistrySupplier = observationRegistrySupplier;
    }

Before adjustment:

image

the method name missing wiith Spring 6.1.x

Now:

image

Meanwhile, optimize test cases of spring-scheduled.

wu-sheng
wu-sheng reviewed May 13, 2024
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
@wu-sheng wu-sheng added this to the 9.3.0 milestone May 13, 2024
@wu-sheng wu-sheng added enhancement New feature or request plugin labels May 13, 2024
@wu-sheng
Copy link
Member

wu-sheng commented May 13, 2024

I can see RocketMQ case fails again.

@CzyerChen
Copy link
Contributor Author

CzyerChen commented May 14, 2024

I can see RocketMQ case fails again.

OK，I will check RocketMQ case first.

@CzyerChen
Copy link
Contributor Author

CzyerChen commented May 14, 2024

I can see RocketMQ case fails again.

The problem is not reproduced locally, and the sending and receiving of async messages are enhanced.

Please do inform me when the recurrence of the problem.

@wu-sheng
Copy link
Member

wu-sheng commented May 14, 2024

Are we sending too frequently? The test GHA env is only 3u8g for all runtime. It could be super slow.

wu-sheng
wu-sheng previously approved these changes May 14, 2024
View reviewed changes
@CzyerChen
Copy link
Contributor Author

CzyerChen commented May 14, 2024

Are we sending too frequently? The test GHA env is only 3u8g for all runtime. It could be super slow.

May have an impact.

@wu-sheng
Copy link
Member

wu-sheng commented May 14, 2024

I can see RocketMQ fails again. From what I see, 50% chance fails

@wu-sheng wu-sheng merged commit 4dfc1e8 into apache:main May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request plugin

Projects

None yet

Milestone

9.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@CzyerChen @wu-sheng
Morty Proxy This is a proxified and sanitized view of the page, visit original site.