From 78189b3f289431460cad15b40ab287868eea11b4 Mon Sep 17 00:00:00 2001 From: "blue.cheng" <=> Date: Fri, 26 Apr 2024 19:41:55 +0800 Subject: [PATCH 1/4] Set the log flush thread to Daemon --- .../skywalking/apm/agent/core/logging/core/FileWriter.java | 1 + 1 file changed, 1 insertion(+) diff --git a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/core/FileWriter.java b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/core/FileWriter.java index 4020b7a98a..adc7194e45 100644 --- a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/core/FileWriter.java +++ b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/core/FileWriter.java @@ -97,6 +97,7 @@ public void run() { public void handle(Throwable t) { } }), "SkywalkingAgent-LogFileWriter"); + logFlusherThread.setDaemon(true); logFlusherThread.start(); } From c3e2cf5a8cb1c0743220b72b137f513884e1119f Mon Sep 17 00:00:00 2001 From: "blue.cheng" <=> Date: Fri, 26 Apr 2024 20:09:08 +0800 Subject: [PATCH 2/4] update CHANGES.md --- CHANGES.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGES.md b/CHANGES.md index 790ba4c6dc..ddd8096e89 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -8,6 +8,7 @@ Release Notes. * Remove `idleCount` tag in Alibaba Druid meter plugin. * Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. * Support for C3P0 connection pool tracing. +* Set log flush log thread to daemon All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/213?closed=1) From afc4282ea5a79d3eb2235fcb2120446b8a3518f3 Mon Sep 17 00:00:00 2001 From: "blue.cheng" <=> Date: Fri, 26 Apr 2024 20:20:38 +0800 Subject: [PATCH 3/4] update CHANGES.md --- CHANGES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index ddd8096e89..1e190575e1 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -8,7 +8,7 @@ Release Notes. * Remove `idleCount` tag in Alibaba Druid meter plugin. * Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. * Support for C3P0 connection pool tracing. -* Set log flush log thread to daemon +* Set log flush thread to daemon All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/213?closed=1) From 451b553e0e966cdb20e8c1028d7c4965a9eeb364 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=90=B4=E6=99=9F=20Wu=20Sheng?= Date: Fri, 26 Apr 2024 21:09:46 +0800 Subject: [PATCH 4/4] Update CHANGES.md --- CHANGES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 1e190575e1..ba2cd6cb70 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -8,7 +8,7 @@ Release Notes. * Remove `idleCount` tag in Alibaba Druid meter plugin. * Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. * Support for C3P0 connection pool tracing. -* Set log flush thread to daemon +* Use a daemon thread to flush logs. All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/213?closed=1)