[RIP-78-5]: Add refactored backend files#313
[RIP-78-5]: Add refactored backend files#313RongtongJin merged 1 commit intoapache:masterapache/rocketmq-dashboard:masterfrom
Conversation
|
Hello @Crazylychee and good job. There are some remaining refactoring about Spring Boot. As an example we can remove the use of |
Oh, I get it. You may mean that we can replace the '@Autowired' and '@resource' of using the Allargsconstructor. That's a good idea. And are you willing to take a pr based on the lastest master? |
|
@Crazylychee Good point, I will take a look on it. |
What is the purpose of the change
[RIP-78] part05
Brief changelog
fix #303
fix #305
fix #294
fix #245
fix #243
fix #264
fix #308
Verifying this change
jdk8 to jdk17
springboot 2.6 to springboot 3.4.5
remove acl1.0 and support acl2.0
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.