Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Resolve the bug without encode batch flag when send batch message#152

Merged
jonnxu merged 1 commit intoapache:masterapache/rocketmq-client-cpp:masterfrom
jonnxu:issue_batchCopy head branch name to clipboard
Jun 18, 2019
Merged

Resolve the bug without encode batch flag when send batch message#152
jonnxu merged 1 commit intoapache:masterapache/rocketmq-client-cpp:masterfrom
jonnxu:issue_batchCopy head branch name to clipboard

Conversation

@jonnxu
Copy link
Copy Markdown
Contributor

@jonnxu jonnxu commented Jun 2, 2019

What is the purpose of the change

Resolve the issue for send batch message

Brief changelog

Resolve the bug when send batch message without encode batch flag in SendMessageRequestHeader

Verifying this change

SendResult: sendStatus:0,msgId:010011AC0000F15A000082BE6D0F0200,offsetMsgId:0BC1F01E00002A9F0000022B24C575D4,queueOffset:5467,transactionId:,messageQueue:MessageQueue [topic=MQ_INST_*************_BaoCMwkE%t-common-message, brokerName=qd5internet-01, queueId=1]

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@jonnxu jonnxu mentioned this pull request Jun 3, 2019
3 tasks
@ShannonDing ShannonDing added the enhancement New feature or request label Jun 12, 2019
@ShannonDing ShannonDing added this to the 1.2.3 milestone Jun 12, 2019
Copy link
Copy Markdown
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonnxu jonnxu merged commit 390bfe6 into apache:master Jun 18, 2019
@jonnxu jonnxu deleted the issue_batch branch July 24, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.