Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #9994] Improve switchTimerEngine command with OptionGroup validation#9995

Merged
RongtongJin merged 1 commit intoapache:developapache/rocketmq:developfrom
majialoong:ISSUE-9994majialoong/rocketmq:ISSUE-9994Copy head branch name to clipboard
Jan 8, 2026
Merged

[ISSUE #9994] Improve switchTimerEngine command with OptionGroup validation#9995
RongtongJin merged 1 commit intoapache:developapache/rocketmq:developfrom
majialoong:ISSUE-9994majialoong/rocketmq:ISSUE-9994Copy head branch name to clipboard

Conversation

@majialoong
Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Fixes #9994

Brief Description

Improve switchTimerEngine command with OptionGroup validation.

How Did You Test This Change?

Unit test and local test.

image

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.78%. Comparing base (7fc5452) to head (d3a7abd).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9995      +/-   ##
=============================================
- Coverage      48.82%   48.78%   -0.05%     
+ Complexity     12779    12769      -10     
=============================================
  Files           1327     1327              
  Lines          96441    96441              
  Branches       12440    12440              
=============================================
- Hits           47088    47049      -39     
- Misses         43613    43630      +17     
- Partials        5740     5762      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@majialoong
Copy link
Copy Markdown
Contributor Author

This PR addresses the discussion in 9787. @RongtongJin Please take a look when you have time, Thanks!

@RongtongJin RongtongJin merged commit 4c66580 into apache:develop Jan 8, 2026
15 of 19 checks passed
@majialoong majialoong deleted the ISSUE-9994 branch January 26, 2026 12:00
dingshuangxi888 pushed a commit to dingshuangxi888/rocketmq that referenced this pull request Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Improve switchTimerEngine command with OptionGroup validation

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.