[ISSUE #9923] Transactional messages should not send custom delayed messages#9924
Merged
RongtongJin merged 2 commits intoapache:developapache/rocketmq:developfrom Jan 8, 2026
Merged
[ISSUE #9923] Transactional messages should not send custom delayed messages#9924RongtongJin merged 2 commits intoapache:developapache/rocketmq:developfrom
RongtongJin merged 2 commits intoapache:developapache/rocketmq:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9924 +/- ##
=============================================
- Coverage 48.91% 48.79% -0.12%
+ Complexity 12770 12736 -34
=============================================
Files 1324 1324
Lines 96288 96297 +9
Branches 12409 12411 +2
=============================================
- Hits 47097 46989 -108
- Misses 43458 43554 +96
- Partials 5733 5754 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
humkum
reviewed
Dec 15, 2025
| MessageAccessor.clearProperty(msg, MessageConst.PROPERTY_DELAY_TIME_LEVEL); | ||
| } | ||
| if (msg.getDelayTimeMs() != 0) { | ||
| MessageAccessor.clearProperty(msg, MessageConst.PROPERTY_TIMER_DELAY_MS); |
Contributor
There was a problem hiding this comment.
In this situation, it is recommended to throw an exception directly, so that the user can perceive the usage error.
Contributor
Author
There was a problem hiding this comment.
I've thought about that too. Currently, the processing is consistent with the existing level. But if an exception is thrown, will there be semantic differences after the user upgrades?
RongtongJin
approved these changes
Dec 18, 2025
dingshuangxi888
pushed a commit
to dingshuangxi888/rocketmq
that referenced
this pull request
Feb 10, 2026
…ayed messages (apache#9924) * [ISSUE apache#9923] Transactional messages should not send custom delayed messages * Transactional messages do not support delayed delivery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9923 .