Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #9418] Fix ColumnFamilyHandle not close in PopConsumerRocksdbStore#9420

Merged
lizhimins merged 1 commit intoapache:developapache/rocketmq:developfrom
lizhimins:issue-9418lizhimins/rocketmq:issue-9418Copy head branch name to clipboard
May 21, 2025
Merged

[ISSUE #9418] Fix ColumnFamilyHandle not close in PopConsumerRocksdbStore#9420
lizhimins merged 1 commit intoapache:developapache/rocketmq:developfrom
lizhimins:issue-9418lizhimins/rocketmq:issue-9418Copy head branch name to clipboard

Conversation

@lizhimins
Copy link
Copy Markdown
Member

…tore

Which Issue(s) This PR Fixes

Fixes #9418

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 21, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 47.89%. Comparing base (e1021ec) to head (22a5e09).
⚠️ Report is 248 commits behind head on develop.

Files with missing lines Patch % Lines
...e/rocketmq/broker/pop/PopConsumerRocksdbStore.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9420      +/-   ##
=============================================
- Coverage      47.90%   47.89%   -0.01%     
- Complexity     11891    11893       +2     
=============================================
  Files           1307     1307              
  Lines          92020    92020              
  Branches       11775    11775              
=============================================
- Hits           44081    44076       -5     
- Misses         42453    42461       +8     
+ Partials        5486     5483       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@qianye1001 qianye1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit c9ea749 into apache:develop May 21, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fix ColumnFamilyHandle not close in PopConsumerRocksdbStore

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.