Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #9379] Fix timeStoreTable delete logic in IndexService#9384

Merged
RongtongJin merged 2 commits intoapache:developapache/rocketmq:developfrom
lizhimins:fix-9379lizhimins/rocketmq:fix-9379Copy head branch name to clipboard
May 6, 2025
Merged

[ISSUE #9379] Fix timeStoreTable delete logic in IndexService#9384
RongtongJin merged 2 commits intoapache:developapache/rocketmq:developfrom
lizhimins:fix-9379lizhimins/rocketmq:fix-9379Copy head branch name to clipboard

Conversation

@lizhimins
Copy link
Copy Markdown
Member

Which Issue(s) This PR Fixes

Fixes #9379

Brief Description

How Did You Test This Change?

Copy link
Copy Markdown
Contributor

@dingshuangxi888 dingshuangxi888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 6, 2025

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.00%. Comparing base (c9deaa5) to head (0386236).
⚠️ Report is 61 commits behind head on develop.

Files with missing lines Patch % Lines
.../rocketmq/tieredstore/index/IndexStoreService.java 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9384      +/-   ##
=============================================
- Coverage      48.05%   48.00%   -0.06%     
+ Complexity     11922    11901      -21     
=============================================
  Files           1307     1307              
  Lines          92010    92016       +6     
  Branches       11781    11781              
=============================================
- Hits           44217    44169      -48     
- Misses         42312    42349      +37     
- Partials        5481     5498      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@qianye1001 qianye1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin RongtongJin merged commit c66e758 into apache:develop May 6, 2025
10 of 11 checks passed
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
…pache#9384)

* [ISSUE apache#9379] Fix timeStoreTable delete logic in IndexService

* [ISSUE apache#9379] Fix delete logic from TimeStoreTable in IndexService
RongtongJin pushed a commit that referenced this pull request Jul 19, 2025
* [ISSUE #9379] Fix timeStoreTable delete logic in IndexService

* [ISSUE #9379] Fix delete logic from TimeStoreTable in IndexService
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fix delete logic from TimeStoreTable in IndexService

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.