Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #9360] Fix some services are not shut down when the broker goes offline#9361

Merged
lizhimins merged 1 commit intoapache:developapache/rocketmq:developfrom
lizhimins:fix-9360lizhimins/rocketmq:fix-9360Copy head branch name to clipboard
Apr 23, 2025
Merged

[ISSUE #9360] Fix some services are not shut down when the broker goes offline#9361
lizhimins merged 1 commit intoapache:developapache/rocketmq:developfrom
lizhimins:fix-9360lizhimins/rocketmq:fix-9360Copy head branch name to clipboard

Conversation

@lizhimins
Copy link
Copy Markdown
Member

Which Issue(s) This PR Fixes

Fixes #9360

Brief Description

How Did You Test This Change?

Copy link
Copy Markdown
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 23, 2025

Codecov Report

❌ Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.08%. Comparing base (1babb32) to head (d7fc8e1).
⚠️ Report is 267 commits behind head on develop.

Files with missing lines Patch % Lines
...a/org/apache/rocketmq/broker/BrokerController.java 30.00% 1 Missing and 6 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9361      +/-   ##
=============================================
- Coverage      48.10%   48.08%   -0.02%     
+ Complexity     12133    12130       -3     
=============================================
  Files           1323     1323              
  Lines          93397    93404       +7     
  Branches       11998    12003       +5     
=============================================
- Hits           44925    44914      -11     
- Misses         42917    42921       +4     
- Partials        5555     5569      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins merged commit 61f50b0 into apache:develop Apr 23, 2025
10 of 11 checks passed
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fix some services are not shutdown when the broker offline

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.