Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #8968] Introduce the clearRetryTopicWhenDeleteTopic option to enable precise external deletion of topics#8969

Merged
ltamber merged 3 commits intoapache:developapache/rocketmq:developfrom
RongtongJin:dev-1121RongtongJin/rocketmq:dev-1121Copy head branch name to clipboard
Nov 27, 2024
Merged

[ISSUE #8968] Introduce the clearRetryTopicWhenDeleteTopic option to enable precise external deletion of topics#8969
ltamber merged 3 commits intoapache:developapache/rocketmq:developfrom
RongtongJin:dev-1121RongtongJin/rocketmq:dev-1121Copy head branch name to clipboard

Conversation

@RongtongJin
Copy link
Copy Markdown
Contributor

@RongtongJin RongtongJin commented Nov 21, 2024

Which Issue(s) This PR Fixes

Fixes #8968

Brief Description

  1. Introduce the clearRetryTopicWhenDeleteTopic option to enable precise external deletion of topics, eliminating the need to traverse consumerOffsetTable and thereby enhancing performance.

  2. Add the setConsumerOffsetManager interface to simplify external customization.

How Did You Test This Change?

…on of topics externally without the need to traverse consumerOffset
@RongtongJin RongtongJin changed the title Introduce the clearRetryTopicWhenDeleteTopic option to enable precise external deletion of topics [ISSUE #8968] Introduce the clearRetryTopicWhenDeleteTopic option to enable precise external deletion of topics Nov 21, 2024
@RongtongJin RongtongJin marked this pull request as draft November 21, 2024 09:24
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 21, 2024

Codecov Report

❌ Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.64%. Comparing base (a8779c0) to head (13029c0).
⚠️ Report is 240 commits behind head on develop.

Files with missing lines Patch % Lines
.../java/org/apache/rocketmq/common/BrokerConfig.java 25.00% 3 Missing ⚠️
...a/org/apache/rocketmq/broker/BrokerController.java 0.00% 2 Missing ⚠️
...ocketmq/broker/processor/AdminBrokerProcessor.java 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8969      +/-   ##
=============================================
- Coverage      47.70%   47.64%   -0.06%     
+ Complexity     11782    11762      -20     
=============================================
  Files           1304     1304              
  Lines          91188    91199      +11     
  Branches       11713    11715       +2     
=============================================
- Hits           43502    43454      -48     
- Misses         42315    42367      +52     
- Partials        5371     5378       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RongtongJin RongtongJin marked this pull request as ready for review November 21, 2024 09:31
Copy link
Copy Markdown
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ltamber ltamber merged commit 3ae0139 into apache:develop Nov 27, 2024
RongtongJin added a commit that referenced this pull request Jul 19, 2025
…enable precise external deletion of topics (#8969)

* Add the clearRetryTopicWhenDeleteTopic option to allow precise deletion of topics externally without the need to traverse consumerOffset

* Fix check style
ChineseTony pushed a commit to ChineseTony/rocketmq that referenced this pull request Aug 8, 2025
…on to enable precise external deletion of topics (apache#8969)

* Add the clearRetryTopicWhenDeleteTopic option to allow precise deletion of topics externally without the need to traverse consumerOffset

* Fix check style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Introduce the clearRetryTopicWhenDeleteTopic option to enable precise external deletion of topics

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.