[ISSUE #8963] Fix code36 request sent to ns#8964
Merged
yuz10 merged 2 commits intoapache:developapache/rocketmq:developfrom Nov 27, 2024
Merged
[ISSUE #8963] Fix code36 request sent to ns#8964yuz10 merged 2 commits intoapache:developapache/rocketmq:developfrom
yuz10 merged 2 commits intoapache:developapache/rocketmq:developfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8964 +/- ##
=============================================
- Coverage 47.73% 47.66% -0.08%
+ Complexity 11774 11769 -5
=============================================
Files 1304 1304
Lines 91118 91201 +83
Branches 11692 11717 +25
=============================================
- Hits 43495 43470 -25
- Misses 42264 42345 +81
- Partials 5359 5386 +27 ☔ View full report in Codecov by Sentry. |
yuz10
previously approved these changes
Nov 21, 2024
humkum
approved these changes
Nov 21, 2024
RongtongJin
previously approved these changes
Nov 22, 2024
ltamber
reviewed
Nov 25, 2024
| } else { | ||
| String brokerAddr = (null != brokerName) ? this.mQClientFactory.findBrokerAddressInPublish(brokerName) | ||
| : RemotingHelper.parseSocketAddressAddr(msg.getStoreHost()); | ||
| if (UtilAll.isBlank(brokerAddr)) { |
Contributor
There was a problem hiding this comment.
Will this code have the same issue ?
Contributor
Author
There was a problem hiding this comment.
Logically, it is the same as push and will have this problem, but notice that it has been marked as @Deprecated. Does it need to be modified?
Contributor
There was a problem hiding this comment.
IMO, maybe someone still using this, it would be better to modify.
Contributor
Author
There was a problem hiding this comment.
OK, I will change it together.
yuz10
approved these changes
Nov 27, 2024
RongtongJin
pushed a commit
that referenced
this pull request
Jul 19, 2025
ChineseTony
pushed a commit
to ChineseTony/rocketmq
that referenced
this pull request
Aug 8, 2025
* [ISSUE apache#8963] Fix code36 request sent to ns * Update DefaultMQPullConsumerImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8963 .