Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #8850] Use correct log method#8851

Merged
lizhanhui merged 1 commit intoapache:developapache/rocketmq:developfrom
mawen12:bugfix-log-methodmawen12/rocketmq:bugfix-log-methodCopy head branch name to clipboard
Oct 23, 2024
Merged

[ISSUE #8850] Use correct log method#8851
lizhanhui merged 1 commit intoapache:developapache/rocketmq:developfrom
mawen12:bugfix-log-methodmawen12/rocketmq:bugfix-log-methodCopy head branch name to clipboard

Conversation

@mawen12
Copy link
Copy Markdown
Contributor

@mawen12 mawen12 commented Oct 22, 2024

Which Issue(s) This PR Fixes

Fixes #8850

Brief Description

The NettyBridgeLogger#trace method should call Logger#trace, but it call Logger#info method.

How Did You Test This Change?

No test.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 47.37%. Comparing base (a024dc8) to head (f550949).
Report is 108 commits behind head on develop.

Files with missing lines Patch % Lines
...rg/apache/rocketmq/remoting/netty/NettyLogger.java 8.33% 11 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8851      +/-   ##
=============================================
- Coverage      47.45%   47.37%   -0.08%     
+ Complexity     11621    11598      -23     
=============================================
  Files           1284     1284              
  Lines          90023    90023              
  Branches       11586    11586              
=============================================
- Hits           42719    42648      -71     
- Misses         42063    42123      +60     
- Partials        5241     5252      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin changed the title use correct log method [ISSUE #8850] Use correct log method Oct 23, 2024
@lizhanhui lizhanhui merged commit 7f8667a into apache:develop Oct 23, 2024
RongtongJin pushed a commit that referenced this pull request Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] NettyBridgeLogger method mismatch with underlaying methd

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.