[ISSUE #8835]When ck is in the buffer, incomplete ack will lead to message duplication.#8836
Merged
RongtongJin merged 2 commits intoapache:developapache/rocketmq:developfrom Oct 17, 2024
Merged
[ISSUE #8835]When ck is in the buffer, incomplete ack will lead to message duplication.#8836RongtongJin merged 2 commits intoapache:developapache/rocketmq:developfrom
RongtongJin merged 2 commits intoapache:developapache/rocketmq:developfrom
Conversation
Contributor
Author
|
The reason for this issue is that the Ack was put to store from the buffer without writing the brokerName. This variable is essential during the merge process. |
RongtongJin
approved these changes
Oct 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8836 +/- ##
=============================================
- Coverage 47.42% 47.39% -0.04%
- Complexity 11514 11599 +85
=============================================
Files 1277 1283 +6
Lines 89438 90010 +572
Branches 11502 11584 +82
=============================================
+ Hits 42416 42657 +241
- Misses 41812 42111 +299
- Partials 5210 5242 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RongtongJin
pushed a commit
that referenced
this pull request
Jul 19, 2025
…essage duplication. (#8836) * add brokerName in ackMsg * add brokerName in ackMsg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8835
Brief Description
How Did You Test This Change?