Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[ISSUE #8806] Fix autoBatch bug when connecting multiple RocketMQ clusters.#8807

Merged
RongtongJin merged 1 commit intoapache:developapache/rocketmq:developfrom
luozongle01:issue8806luozongle01/rocketmq:issue8806Copy head branch name to clipboard
Oct 11, 2024
Merged

[ISSUE #8806] Fix autoBatch bug when connecting multiple RocketMQ clusters.#8807
RongtongJin merged 1 commit intoapache:developapache/rocketmq:developfrom
luozongle01:issue8806luozongle01/rocketmq:issue8806Copy head branch name to clipboard

Conversation

@luozongle01
Copy link
Copy Markdown
Contributor

@luozongle01 luozongle01 commented Oct 10, 2024 •
edited
Loading

Which Issue(s) This PR Fixes

Fixes #8806

Brief Description

  1. Delay the creation of the ProducerAccumulator until startup. Since instanceName will change at startup, and unitName should already be set at this time.
  2. Due to delaying the ProducerAccumulator to create, in order to allow users to set the parameters of batchMaxDelayMs, batchMaxbytes, and totaled BatchMaxbytes in the Producer Accumulator before executing the start method (Because I am worried that some users may set these parameters before executing start), three properties have been added to the DefaultMQProducer. After the ProducerAccumulator is initialized, it is assigned to the ProducerAccumulator.

How Did You Test This Change?

I have tested locally and confirmed that it will not be sent to other RocketMQ clusters, and the parameter settings can take effect.
image
image

guyinyou
guyinyou approved these changes Oct 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RongtongJin RongtongJin merged commit 11f0002 into apache:develop Oct 11, 2024
RongtongJin pushed a commit that referenced this pull request Jul 19, 2025
@luozongle01 @RongtongJin
[ISSUE #8806] fix autoBatch bug when connecting multiple RocketMQ clu…
86293e5 
…sters. (#8807)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RongtongJin RongtongJin RongtongJin approved these changes

+1 more reviewer

@guyinyou guyinyou guyinyou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] AutoBatch bug when connecting multiple RocketMQ clusters.

3 participants

@luozongle01 @RongtongJin @guyinyou
Morty Proxy This is a proxified and sanitized view of the page, visit original site.