Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #8790] Add Utils for put header to Metadata to avoid duplicate data#8792

Merged
lollipopjin merged 1 commit intoapache:developapache/rocketmq:developfrom
dingshuangxi888:hotfix/avoid_metadata_duplicateCopy head branch name to clipboard
Oct 9, 2024
Merged

[ISSUE #8790] Add Utils for put header to Metadata to avoid duplicate data#8792
lollipopjin merged 1 commit intoapache:developapache/rocketmq:developfrom
dingshuangxi888:hotfix/avoid_metadata_duplicateCopy head branch name to clipboard

Conversation

@dingshuangxi888
Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Add Utils for put header to gRPC Metadata to avoid duplicate data.

Fixes #8790

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 8, 2024

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.34%. Comparing base (782da70) to head (feeac3f).
⚠️ Report is 445 commits behind head on develop.

Files with missing lines Patch % Lines
.../apache/rocketmq/proxy/common/utils/GrpcUtils.java 0.00% 9 Missing ⚠️
...etmq/proxy/grpc/interceptor/HeaderInterceptor.java 0.00% 4 Missing ⚠️
...xy/grpc/interceptor/AuthenticationInterceptor.java 0.00% 3 Missing ⚠️
...mq/proxy/grpc/pipeline/AuthenticationPipeline.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8792      +/-   ##
=============================================
- Coverage      47.43%   47.34%   -0.10%     
+ Complexity     11569    11554      -15     
=============================================
  Files           1282     1283       +1     
  Lines          89864    89873       +9     
  Branches       11563    11565       +2     
=============================================
- Hits           42627    42550      -77     
- Misses         41986    42072      +86     
  Partials        5251     5251              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins changed the title [ISSUE #8790]Add Utils for put header to Metadata to avoid duplicate data. [ISSUE #8790] Add Utils for put header to Metadata to avoid duplicate data Oct 9, 2024
Copy link
Copy Markdown
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 95b1c51 into apache:develop Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Add Utils for put header to gRPC Metadata to avoid duplicate data.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.