Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #8549] Ipv6 enabled in broker, pickupStoreTimestamp size should be 20#8567

Merged
RongtongJin merged 2 commits intoapache:developapache/rocketmq:developfrom
leizhiyuan:fix/8549leizhiyuan/rocketmq:fix/8549Copy head branch name to clipboard
Aug 21, 2024
Merged

[ISSUE #8549] Ipv6 enabled in broker, pickupStoreTimestamp size should be 20#8567
RongtongJin merged 2 commits intoapache:developapache/rocketmq:developfrom
leizhiyuan:fix/8549leizhiyuan/rocketmq:fix/8549Copy head branch name to clipboard

Conversation

@leizhiyuan
Copy link
Copy Markdown
Contributor

@leizhiyuan leizhiyuan commented Aug 20, 2024

Which Issue(s) This PR Fixes

Fixes #8549

Brief Description

ipv6 enabled in broker, pickupStoreTimestamp size should be 20

How Did You Test This Change?

@leizhiyuan leizhiyuan changed the title [ISSUE #8549] ipv6 enabled in broker, pickupStoreTimestamp size should be 12 [ISSUE #8549] Ipv6 enabled in broker, pickupStoreTimestamp size should be 12 Aug 20, 2024
@leizhiyuan leizhiyuan changed the title [ISSUE #8549] Ipv6 enabled in broker, pickupStoreTimestamp size should be 12 [ISSUE #8549] Ipv6 enabled in broker, pickupStoreTimestamp size should be 20 Aug 20, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.08%. Comparing base (8b7f9cc) to head (978de98).
Report is 71 commits behind head on develop.

Files with missing lines Patch % Lines
...org/apache/rocketmq/store/DefaultMessageStore.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8567      +/-   ##
=============================================
- Coverage      47.15%   47.08%   -0.08%     
+ Complexity     11390    11375      -15     
=============================================
  Files           1275     1275              
  Lines          89108    89111       +3     
  Branches       11467    11468       +1     
=============================================
- Hits           42017    41955      -62     
- Misses         41906    41968      +62     
- Partials        5185     5188       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin merged commit 09beca6 into apache:develop Aug 21, 2024
@jaylu163
Copy link
Copy Markdown

jaylu163 commented Nov 7, 2024

5.2版本还有问题。有修改这个版本吗

@woaishixiaoxiao
Copy link
Copy Markdown
Contributor

woaishixiaoxiao commented Jun 25, 2025

The validator.isValidInet6Address function only supports standard IPv6 addresses. brokerIP1 default get by NetworkUtil.getLocalAddress() will normalize by "[]", such as [2001:0db8:85a3:0000:0000:8a2e:0370:7334] and ipv6 address will contains scope in linux such as [2001:0db8:85a3:0000:0000:8a2e:0370:7334%eth0]. @RongtongJin RongtongJin

RongtongJin pushed a commit that referenced this pull request Jul 19, 2025
…d be 20 (#8567)

* fix: when ipv6 enabled in broker, pickupStoreTimestamp size should be 12(20-8)

* fix: when ipv6 enabled in broker, pickupStoreTimestamp size should be 20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Bug title Rocketmq5.3.0 reports an error after configuring IPV6

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.