Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #8481] Improve delete and rolling strategy for tiered storage modules#8493

Merged
lizhimins merged 2 commits intoapache:developapache/rocketmq:developfrom
lizhimins:develop-8481lizhimins/rocketmq:develop-8481Copy head branch name to clipboard
Aug 6, 2024
Merged

[ISSUE #8481] Improve delete and rolling strategy for tiered storage modules#8493
lizhimins merged 2 commits intoapache:developapache/rocketmq:developfrom
lizhimins:develop-8481lizhimins/rocketmq:develop-8481Copy head branch name to clipboard

Conversation

@lizhimins
Copy link
Copy Markdown
Member

@lizhimins lizhimins commented Aug 5, 2024

[ISSUE #8481] Improve delete and rolling strategy for tiered storage modules

Which Issue(s) This PR Fixes

Fixes #8481

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 5, 2024

Codecov Report

❌ Patch coverage is 50.63291% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.23%. Comparing base (304987d) to head (5e37c69).
⚠️ Report is 544 commits behind head on develop.

Files with missing lines Patch % Lines
.../rocketmq/tieredstore/index/IndexStoreService.java 30.76% 15 Missing and 3 partials ⚠️
...pache/rocketmq/tieredstore/file/FlatFileStore.java 0.00% 15 Missing ⚠️
...pache/rocketmq/tieredstore/TieredMessageStore.java 71.42% 0 Missing and 2 partials ⚠️
...pache/rocketmq/tieredstore/MessageStoreConfig.java 88.88% 1 Missing ⚠️
...etmq/tieredstore/core/MessageStoreFetcherImpl.java 90.00% 0 Missing and 1 partial ⚠️
...e/rocketmq/tieredstore/file/FlatCommitLogFile.java 80.00% 0 Missing and 1 partial ⚠️
...pache/rocketmq/tieredstore/index/IndexService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8493      +/-   ##
=============================================
+ Coverage      45.94%   46.23%   +0.28%     
- Complexity     11107    11207     +100     
=============================================
  Files           1274     1275       +1     
  Lines          89001    89061      +60     
  Branches       11441    11454      +13     
=============================================
+ Hits           40893    41177     +284     
+ Misses         43011    42751     -260     
- Partials        5097     5133      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@LetLetMe LetLetMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常好写的

@lizhimins lizhimins merged commit f63a3ba into apache:develop Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Improve delete and rolling strategy for tiered storage modules

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.