Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #8472] Fix pop message delay due to not notify message arriving after suspend#8473

Merged
lizhimins merged 1 commit intoapache:developapache/rocketmq:developfrom
lizhimins:fix-pop-delaylizhimins/rocketmq:fix-pop-delayCopy head branch name to clipboard
Aug 1, 2024
Merged

[ISSUE #8472] Fix pop message delay due to not notify message arriving after suspend#8473
lizhimins merged 1 commit intoapache:developapache/rocketmq:developfrom
lizhimins:fix-pop-delaylizhimins/rocketmq:fix-pop-delayCopy head branch name to clipboard

Conversation

@lizhimins
Copy link
Copy Markdown
Member

Which Issue(s) This PR Fixes

Fixes #8472

Brief Description

How Did You Test This Change?

@qianye1001
Copy link
Copy Markdown
Contributor

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.00%. Comparing base (8fe3451) to head (6b75015).

Files Patch % Lines
...rocketmq/broker/processor/PopMessageProcessor.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8473      +/-   ##
=============================================
- Coverage      46.04%   46.00%   -0.05%     
- Complexity     11147    11148       +1     
=============================================
  Files           1274     1274              
  Lines          89000    89003       +3     
  Branches       11443    11444       +1     
=============================================
- Hits           40979    40942      -37     
- Misses         42905    42932      +27     
- Partials        5116     5129      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit cd23d6d into apache:develop Aug 1, 2024
RongtongJin pushed a commit that referenced this pull request Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fix pop message delay due to not notify message arriving after suspend

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.